Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support empty subscription marbles #5502

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jun 16, 2020

Description:

Correctly interprets subscription marble diagrams that do not include a subscribe character as not being subscription expectations. See related issue for more details.

This PR adds failing tests and then filters subscription logs that are associated with marbles that lack subscription characters.

Related issue (if exists): #5499

@benlesh benlesh merged commit e65696e into ReactiveX:master Jun 22, 2020
@cartant cartant deleted the issue-5499 branch September 24, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants